Make the units consistent in the project
At the moment, there are functions, such as most of the functions in the Wavefield part accept angles only in radians, while at the same time other functions, such as functions in the virtual sensing part accept angles only in radians. It would be good to make all functions consistent on the units they accept.
There are functions, such as the rotMat3d()
that accept radians by default but they allow for degrees by setting an argument to true
. Whether this is the approach decided to follow for all functions or not, it would be great to agree to a universal unit, not only for angles but for all quantities, that will be the default unit that the functions accept. This shouldn’t be an issue as there exist easy ways (such as the built-in rad2deg()
and deg2rad()
functions) to perform conversion between units.