From cd5b53389273daeb092b5f4e903846ef99cb87d7 Mon Sep 17 00:00:00 2001
From: Stephen C Phillips <steve@scphillips.com>
Date: Fri, 3 Apr 2020 13:33:37 +0100
Subject: [PATCH] Moved ARG below FROM (otherwise they are ignored)

---
 docker/Dockerfile_test | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/docker/Dockerfile_test b/docker/Dockerfile_test
index ec9a2a8..0cc6d40 100644
--- a/docker/Dockerfile_test
+++ b/docker/Dockerfile_test
@@ -1,25 +1,14 @@
 ARG GCP_HOST
-
 ARG GCP_PROJECT_ID
-
 ARG CI_COMMIT_SHORT_SHA
 
 #FROM $GCP_HOST/$GCP_PROJECT_ID/build-img:$CI_COMMIT_SHORT_SHA
 FROM build-img:$CI_COMMIT_SHORT_SHA
 
-ENV MONGO_MONGODB_SERVICE_HOST mongo-server-12345qwerty
-ENV MONGODB_ROOT_PASSWORD root
-
-MAINTAINER bob2
+ARG MONGODB_ROOT_PASSWORD
+ARG MONGO_MONGODB_SERVICE_HOST
 
 RUN sed -i 's/spring.data.mongodb.host=localhost/spring.data.mongodb.host='"$MONGO_MONGODB_SERVICE_HOST"'/g' /src/main/resources/application.properties
-
 RUN sed -i 's/# Mongo/# Mongo\nspring.data.mongodb.username=root\nspring.data.mongodb.password='"$MONGODB_ROOT_PASSWORD"'\nspring.data.mongodb.authentication-database=admin/g' /src/main/resources/application.properties
 
-ENV CI_COMMIT_SHORT_SHA bobbb
-
-RUN echo $MONGO_MONGODB_SERVICE_HOST
-
-RUN grep -i mongo /src/main/resources/application.properties
-
 RUN gradle test
-- 
GitLab