From 246611b2f21882168e6017d1a4c5aa8a5c7b4da9 Mon Sep 17 00:00:00 2001
From: Minyong Li <ml10g20@soton.ac.uk>
Date: Mon, 5 Jul 2021 21:51:43 +0100
Subject: [PATCH] core: remove default values in parameters
The top level should pass all parameter down.
---
.../uk/ac/soton/ecs/can/core/CanCoreConfiguration.scala | 8 ++++----
src/main/scala/uk/ac/soton/ecs/can/core/DataMemory.scala | 2 +-
.../scala/uk/ac/soton/ecs/can/core/ProgramMemory.scala | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main/scala/uk/ac/soton/ecs/can/core/CanCoreConfiguration.scala b/src/main/scala/uk/ac/soton/ecs/can/core/CanCoreConfiguration.scala
index 9919bf5..1b94630 100644
--- a/src/main/scala/uk/ac/soton/ecs/can/core/CanCoreConfiguration.scala
+++ b/src/main/scala/uk/ac/soton/ecs/can/core/CanCoreConfiguration.scala
@@ -3,8 +3,8 @@ package uk.ac.soton.ecs.can.core
case class CanCoreConfiguration(
programMemoryWords: Int,
dataMemoryWords: Int,
- syncReadMemory: Boolean = true,
- regAfterBlockInitializer: Boolean = true,
- regBetweenRounds: Boolean = true,
- regAfterAdder: Boolean = true
+ syncReadMemory: Boolean,
+ regAfterBlockInitializer: Boolean,
+ regBetweenRounds: Boolean,
+ regAfterAdder: Boolean
)
diff --git a/src/main/scala/uk/ac/soton/ecs/can/core/DataMemory.scala b/src/main/scala/uk/ac/soton/ecs/can/core/DataMemory.scala
index 62e1c14..9eaf108 100644
--- a/src/main/scala/uk/ac/soton/ecs/can/core/DataMemory.scala
+++ b/src/main/scala/uk/ac/soton/ecs/can/core/DataMemory.scala
@@ -9,7 +9,7 @@ class DataMemory(
addrWidth: Int,
dataWidth: Int,
size: Int,
- syncMem: Boolean = true
+ syncMem: Boolean
) extends MultiIOModule {
val read = IO(
Vec(
diff --git a/src/main/scala/uk/ac/soton/ecs/can/core/ProgramMemory.scala b/src/main/scala/uk/ac/soton/ecs/can/core/ProgramMemory.scala
index f599725..5074434 100644
--- a/src/main/scala/uk/ac/soton/ecs/can/core/ProgramMemory.scala
+++ b/src/main/scala/uk/ac/soton/ecs/can/core/ProgramMemory.scala
@@ -9,7 +9,7 @@ class ProgramMemory(
addrWidth: Int,
cwWidth: Int,
nWords: Int,
- syncMem: Boolean = true
+ syncMem: Boolean
) extends MultiIOModule {
val br = IO(new Bundle {
val abs = Input(Bool())
--
GitLab