From 4bde0f7b0b4269d1f326a22f8bc3a6f9aeb591df Mon Sep 17 00:00:00 2001
From: Clare <chorscroft@users.noreply.github.com>
Date: Wed, 22 Jul 2020 13:14:52 +0100
Subject: [PATCH] New comments for tests on new version
---
cran-comments.md | 38 +++++++++++---------------------------
1 file changed, 11 insertions(+), 27 deletions(-)
diff --git a/cran-comments.md b/cran-comments.md
index 3f3d3d1..064e05e 100644
--- a/cran-comments.md
+++ b/cran-comments.md
@@ -1,43 +1,27 @@
-## Resubmission
+## Changes from previous version
-This is a resubmission. In this version I have:
-
-* added an immediate call to on.exit after changing options so as to not change the user's options outside of the function
-
-Thanks to Martina Schmirl for the suggestion!
+* Can now accept data with missing values
+* New function create_LDprofile for generating an LD profile
+* Updated and improved vignette
+* Fixed noLD issues
## Test environments
* Windows 10 x64
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
* Ubuntu Linux 16.04 LTS, R-release, GCC
* Fedora Linux, R-devel, clang, gfortran
+* Debian Linux, R-release, GCC
+* Debian Linux, R-devel, GCC, no long double
+
+## Results
-## R CMD check results
-There were no ERRORs or WARNINGs or NOTES.
+### NOTES:
-## rhub check results
- * Maintainer: 'Clare Horscroft <c.horscroft@soton.ac.uk>'
- New submission
-
- * Possibly mis-spelled words in DESCRIPTION:
- Kivisild (7:122)
- Sluckin (7:110)
-
* Found the following (possibly) invalid DOIs:
DOI: 10.1534/genetics.115.185900
From: DESCRIPTION
Status: Forbidden
Message: 403
-Mis-spelled words are author names. DOI is correct, https://doi.org/10.1534/genetics.115.185900 goes to the correct reference.
-
-## win_devel check results
- * Maintainer: 'Clare Horscroft <c.horscroft@soton.ac.uk>'
-
- New submission
-
- * Possibly mis-spelled words in DESCRIPTION:
- Kivisild (7:122)
- Sluckin (7:110)
+DOI is correct, https://doi.org/10.1534/genetics.115.185900 goes to the correct reference.
-Mis-spelled words are author names.
--
GitLab